On Tue, Dec 26, 2017 at 02:40:30AM +0100, Jeremie Courreges-Anglas wrote:
> On Sun, Dec 24 2017, Remi Locherer <remi.loche...@relo.ch> wrote:
> > Hi,
> >
> > liblognorm is a library to normalize log messages. It requires libfastjson
> > I sent in the previous mail. It can be used together with rsyslog.
> >
> > The patch is needed to run the test suite. 5 out of the 110 tests fail.
> > I informed the author about the failed tests.
> >
> > I tested on amd64.
> >
> > Reports from other platforms and OKs are welcome.
> 
> No need to keep the TEST_DEPENDS line.  Adding libestr to LIB_DEPENDS is
> sufficient. 

ok, good to know!

> Regarding the patch: there's an easy way to avoid it.
> Regarding the plist,
> 
>   @comment $OpenBSD$
>   @bin bin/lognormalizer
>   include/annot.h
>   include/enc.h
>   include/liblognorm.h
>   include/lognorm-features.h
>   include/lognorm.h
>   include/parser.h
>   include/pdag.h
>   include/samp.h
> 
> I don't think that all those include files (with rather broad names)
> should be installed.  Upstream documentation seems to mention
> liblognorm.h as entry point.  It looks like this is the result of
> a misuse of autotools recipes. Here's an updated tarball that stops
> installing all those headers, with the hope that the patch can be fed
> upstream (make distcheck passes).

Upstream provides all these header files in the "-devel" rpm. The
"regular" rpm that provides the lib does not contain a header file at all.
But that is how it works in the RHEL eco-system.

> Is the resulting package still working for you?

Yes, works for me. My rsyslog wip package compiles with only the
liblognorm.h file installed.

Reply via email to