Stuart Henderson writes:
> On 2018/01/05 19:04, Rafael Sadowski wrote:
> > On Fri Jan 05, 2018 at 03:16:35AM -0700, Anthony J. Bentley wrote:
> > > Hi,
> > > 
> > > IBM Plex is IBM's corporate type family. It is used by IBMers for all
> > > typographical situations, whenever possible.
> > > 
> > > ok?
> > > 
> > 
> > Looks good! Two things, what do you think of that:
> > 
> > GH_TAGNAME =                v0.5.3
> > 
> > DISTNAME =          ibm-plex-${GH_TAGNAME:S/v//}
>
> Plenty of ways to skin that cat :) I find it easier to read without
> the extra regex.

Yeah, I typically just bring in regexes to prevent duplication in
updates (e.g., if the version in distname is 1.0.2 but master_sites
contains 1_0_2, I'll use :S/./_/g). Otherwise I (personally) avoid it.

Reply via email to