On Mon, Jan 08, 2018 at 01:04:05AM +0100, Jeremie Courreges-Anglas wrote:
> On Sun, Jan 07 2018, Stuart Henderson <[email protected]> wrote:
> > On 2018/01/07 10:44, Aaron Bieber wrote:
> >> Harra!
> >>
> >> Here is an update to bring chirp to the latest (as of yesterday).
> >>
> >> - Reformat the Makefile
> >
> > no comment. :-]
>
> That really bothers me.  It makes diffs diffs harder to review and
> cvs(1) blame much less useful.  Aaron, could you avoid this?

Yep! Here is a diff that doesn't diddle the whitespace:
https://deftly.net/patches/chirp-daily-20180104.diff

Also adds devel/py-suds as a run dep (needed for pulling data from one
of the remote data sources

>
> >> - Host dist file on my server, as ftp doesn't like their cert chain
> >
> > The webserver config is broken, it has the server cert but is missing
> > the required chain certificate. Most letsencrypt clients write out a
> > file with both (fullchain.pem instead of cert.pem) and for most
> > webservers you just use fullchain.pem instead of cert.pem. It should
> > be an easy fix for the right person :)
> >
> > (same problem on HOMEPAGE. some annoying graphical browsers auto-fetch
> > the chain cert so a lot of people don't notice anything is wrong until
> > someone tries to use curl/wget/ftp or runs the site through the ssllabs
> > checker..)
> >
> >> -MASTER_SITES=     
> >> http://trac.chirp.danplanet.com/chirp_daily/daily-${MODPY_EGG_VERSION}/
> >> +MASTER_SITES =    https://deftly.net/dist/
> >
> > I would do
> >
> > MASTER_SITES=       
> > https://trac.chirp.danplanet.com/chirp_daily/daily-${MODPY_EGG_VERSION}/ \
> >             https://deftly.net/dist/
> >
> > That way, if they fix it, it should flip straight over to the upstream
> > server, and it keeps the right URL visible in the makefile.
>
> Looks like the right way to handle this.
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

--
PGP: 0x1F81112D62A9ADCE / 3586 3350 BFEA C101 DB1A  4AF0 1F81 112D 62A9 ADCE

Reply via email to