On 2018/01/13 20:02, Sebastien Marie wrote:
> On Sat, Jan 13, 2018 at 02:00:50PM +0000, Stuart Henderson wrote:
> > On 2018/01/13 14:11, Sebastien Marie wrote:
> > > I didn't check RUN_DEPENDS, as I didn't expect command-line change.
> >
> > I wouldn't put it past them to chage command-line again ;)
OK, I've compared the help output from old and new, diff is a bit hard
to read but it seems pretty close so I don't think there will be a problem.
> > > +WANTLIB += ossaudio
> >
> > I don't _think_ we don't want that.. -DWITH_OSS=OFF ?
>
> I am unsure... ossaudio is hardcoded for OpenBSD in CMakeLists.txt (see
> client/common/CMakeLists.txt file). I did few tests, but I couldn't get
> audio (with or without using ossaudio).
There was a big effort to remove ossaudio across as much of the ports
tree as possible (exceptions mostly for mixer use IIRC). It doesn't seem
to be used for anything here and isn't required to build, so I think we
should just patch it away.
--snip -- --- -- --- -- ---
Index: client/common/CMakeLists.txt
--- client/common/CMakeLists.txt.orig
+++ client/common/CMakeLists.txt
@@ -66,11 +66,7 @@ endif()
set(${MODULE_PREFIX}_LIBS ${${MODULE_PREFIX}_LIBS} winpr)
target_link_libraries(${MODULE_NAME} ${PRIVATE_KEYWORD}
${FREERDP_CHANNELS_CLIENT_LIBS})
-if(OPENBSD)
- target_link_libraries(${MODULE_NAME} ${PUBLIC_KEYWORD}
${${MODULE_PREFIX}_LIBS} ossaudio)
-else()
- target_link_libraries(${MODULE_NAME} ${PUBLIC_KEYWORD}
${${MODULE_PREFIX}_LIBS})
-endif()
+target_link_libraries(${MODULE_NAME} ${PUBLIC_KEYWORD}
${${MODULE_PREFIX}_LIBS})
install(TARGETS ${MODULE_NAME} DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT
libraries EXPORT FreeRDP-ClientTargets)
--snip -- --- -- --- -- ---
It might not be all that hard to port to sndio, if somebody actually
wants audio over this..
> I fuck myself with cvs... sorry about that.
>
> diff regenerated.
No worries :)
xfreerdp itself still works for me.
remmina needs cvs rm patch-* then it builds, but doesn't work
properly for me (displays the window, but doesn't do anything if
I enter a hostname and try to connect).
I haven't tried vinagre.
