On Sun, Jan 21, 2018 at 12:07:06AM +0300, Kirill Bychkov wrote: > On Tue, January 16, 2018 22:55, Landry Breuil wrote: > > On Tue, Jan 16, 2018 at 05:27:51PM +0300, Kirill Bychkov wrote: > >> On Tue, January 16, 2018 11:28, Landry Breuil wrote: > >> > On Tue, Jan 16, 2018 at 10:33:07AM +0300, Kirill Bychkov wrote: > >> >> Hi, > >> >> Here is an update to geeqie-1.4. > >> >> Notable port changes: > >> >> - update license marker > >> >> - actually switch it to gtk3 and tweak COMMENT > >> >> (gtk3 as a dependency was introduced some time ago [1], but > >> >> geeqie was still building against gtk2) > >> >> > >> >> Works fine on macppc and amd64. OK to commit? > >> > > >> > I think your mailer mangled the diff: > >> > > >> > patch: **** malformed patch at line 84: README.html ChangeLog.html > >> > > >> > It builds and updates fine, runtime seems ok but there's a weird > >> > behaviour on the left side of the app, it's as if there was an inactive > >> > scrollbar, and not all the content of the sidebar is visible - see > >> > screenshot. > >> > >> Hi, > >> You mean this shortcut sidebar? I've moved the tree sidebar and completely > >> hide shortcuts sidebar which I'm not going to use. You can make this > >> sidebar wider if you need to. > >> Scrollbar for shortcuts appears when one have lots of them or made his > >> filelist sidebar big enough. So nothing weird. See screenshots attached. > > > > The issue i saw at work was that whatever i tried to resize the width of > > the sidebar, it wouldnt display its left side, as if content (ie the > > thumb, or the arrow icon, or the plus icon) would stay displayed 'out of > > the viewport'. On my shot, you dont see the file menu in the top bar, > > nor /home in the path, nor the thumbs.. > > > > I'm able to make sidebar narrow so it's left side also gets hidden. But > making it wider returns all hidden parts of sidebar back. Not sure if > this a feature or a bug. > Probably we should switch back to gtk2? See screenchots attcahed.
Did a bit more testing on another desktop, and i've seen https://github.com/BestImageViewer/geeqie/issues/562 upstream which seems to match the problem we're both seeing. To me, it's a gtk3 bug that wasnt there in 1.3 (maybe?) because a new menu item was added (plugins), i'm not sure the left-side of 'tools' (with homedir/desktop/collections) was here in 1.3 too. Or my local config had it hidden/collapsed, and i cant unhide/uncollapse it. Changing layouts allows to view the full width of the tools widget if it doesnt 'start' on the left of the window. While here there's a bunch of gtk3 warnings on the console which *seems* related: (geeqie:69264): Gtk-WARNING **: Allocating size to GtkBox 0x1b712b50a10 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate? (geeqie:69264): Gtk-WARNING **: Allocating size to GtkWindow 0x1b7327de280 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate? Either way, 1.4 brings one year and a half of improvements, so i think this minor annoyance should prevent us upgrading it :) So okay for me. Landry
