On Fri 09/02/2018 13:44, Landry Breuil wrote:
> On Fri, Feb 09, 2018 at 01:29:36PM +0100, Bjorn Ketelaars wrote:
> > Included a diff for bringing sysutils/burp to the latest version.
> > Changelog can be found at http://burp.grke.org/changelog.html
> > I removed 2 patches as the issues have been solved upstream.
> > Output 'make test':
> > 100%: Checks: 348, Failures: 0, Errors: 0
> > I only did some very, very light testing. Only thing that I'm sure about
> > is that it doesn't blow up.
> I didnt port 2.1 branch on purpose as at that time, upstream considered
> it "development" - but it see now that it's been promoted to stable,
> I know that the timer_script has been internalized, have you tested this
> properly worked (ie having the client connect to the server, and the
> server telling the client if it needs to start a backup or not?)
Nothing has been properly tested! In a nutshell, only thing I tested was:
1.) burp -g
2.) burp -a b
3.) burp -a l
3.) burp -a r -d /tmp/x
I did not verify that the fix of https://github.com/grke/burp/issues/627
actually works. It would be nice to know who created that issue, maybe
he could check :-)