Thomas Frohwein writes:
> ping

For libtheoraplay:

 - Breaks if CFLAGS is set in mk.conf. No need to add to CFLAGS, just
   add -shared and -I to do-build directly
 - Ditto for LDFLAGS
 - Nit: it's okay and often looks better for variable assignments to
   have different indentation levels to avoid wrapping and excessive
   whitespace in the center

Fix CFLAGS and it's ok with me.

Also:

 - libtheorafile doesn't respect CFLAGS

Fix that and it's ok with me.

Reply via email to