On Sun, Feb 18, 2018 at 01:33:39AM +0100, Klemens Nanni wrote: > Simple update shipping lots of (breaking) changes, see > https://github.com/BurntSushi/ripgrep/releases/tag/0.8.0 for changelog. > > Add asciidoc as missing BDEP as well as lang/rust in order to pin the > minimally required version.
Could you point to me the requirement of asciidoc ? I don't have it on any build host and the build seems fine. Additionally I don't find any "a2x" invocation in ripgrep or rust code source neither. > While bumping nearly all crates, update some license markers and use > Apache-2.0/MIT in consistent order. I disagree with the direction to have consistent order for Apache-2.0/MIT. Currently, the list of crates and license is (or should be) generated automatically (see modcargo-gen-crates and modcargo-gen-crates-licenses in port-modules man page) for the crates themself. For me adding a manual pass only for cosmetic is counter-productive. It is more simple to keep the license name used by upstream. > Replace the patch to disable debug symbols with a simpler MAKE_ENV line. no problem. > Move long path into helper variable (OUT_DIR is described here: > https://doc.rust-lang.org/cargo/reference/environment-variables.htmlOUT_DIR) > and adjust post-install to also install fish completions. rg's > permissions are fixed so drop chmod. no problem. > Patch gzip's error message wording that is matched as part of the test > suite so that all tests pass again, at least on my amd64 machine. no problem. Thanks. -- Sebastien Marie
