Here's the updated port.
Personally I didn't like the way the gh stuff looked at the top of the 
Makefile, but I'm starting to get used to it.

At 80 cols the line wraps like this which I'm not crazy about either but 
*shrug*.
"A Tcl extension that provides utilities for comparisons of strings, lists and
files."

Also thanks for the heads-up about GH_ * vs HOMEPAGE.

Stu

> ---------- Original Message ----------
> From: Stuart Henderson <s...@spacehopper.org>
> Date: February 22, 2018 at 1:29 PM
> 
> 
> Please move GH_* up with DISTNAME like is done in other ports and
> Makefile.template, and drop the explicit HOMEPAGE which is nearly
> the same (except http instead of https) as the default for ports
> using GH_*.
> 
> DESCR doesn't need -w 72. Please wrap the >80 column line at the
> start but the rest is ok.
> 
> 
> 
> On 2018/02/22 12:52, Stuart Cassoff wrote:
> > Thanks for having a look!
> > 
> > Yes, the pkg/DESCR is a bit long on a few lines.
> > I ended up doing it like that on purpose in order to get nice descriptive 
> > lines that aren't chopped in awkward places; I find it reads better.
> > 
> > Compare:
> > 
> > A Tcl extension that provides utilities for comparisons of strings, lists 
> > and files.
> > 
> > The base comparison is a Longest Common Substring algorithm based on
> > J. W. Hunt and M. D. McIlroy, "An algorithm for differential file 
> > comparison,"
> > Comp. Sci. Tech. Rep. #41, Bell Telephone Laboratories (1976).
> > Available on the Web at the second author's personal site:
> > http://www.cs.dartmouth.edu/~doug/
> > 
> > It is basically an LCS diff algorithm implemented in C on top of Tcl's API,
> > thus giving full Unicode and VFS support.
> > 
> > 
> > With (fmt -w 72):
> > 
> > 
> > A Tcl extension that provides utilities for comparisons of strings,
> > lists and files.
> > 
> > The base comparison is a Longest Common Substring algorithm based on J.
> > W. Hunt and M. D. McIlroy, "An algorithm for differential file
> > comparison," Comp. Sci. Tech. Rep. #41, Bell Telephone Laboratories
> > (1976).  Available on the Web at the second author's personal site:
> > http://www.cs.dartmouth.edu/~doug/
> > 
> > It is basically an LCS diff algorithm implemented in C on top of Tcl's
> > API, thus giving full Unicode and VFS support.
> > 
> > 
> > If it's really a problem I can live with what I feel is less-than-ideal 
> > formatting.
> > 
> > 
> > Stu
> > 
> > 
> > 
> > > ---------- Original Message ----------
> > > From: Ryan Freeman <r...@slipgate.org>
> > > Date: February 22, 2018 at 11:58 AM
> > > 
> > > 
> > > On Tue, Feb 20, 2018 at 05:56:50PM -0500, Stuart Cassoff wrote:
> > > > > > > > ---------- Original Message ----------
> > > > > > > > From: Stuart Cassoff <3...@bell.net>
> > > > > > > > Date: December 9, 2017 at 11:27 AM
> > > > > > > > 
> > > > > > > > 
> > > > > > > > Comment:
> > > > > > > > diff functions for Tcl
> > > > > > > > 
> > > > > > > > Description:
> > > > > > > > A Tcl extension that provides utilities for comparisons of 
> > > > > > > > strings, lists and files.
> > > > > > > > 
> > > > > > > > The base comparison is a Longest Common Substring algorithm 
> > > > > > > > based on
> > > > > > > > J. W. Hunt and M. D. McIlroy, "An algorithm for differential 
> > > > > > > > file comparison,"
> > > > > > > > Comp. Sci. Tech. Rep. #41, Bell Telephone Laboratories (1976).
> > > > > > > > Available on the Web at the second author's personal site:
> > > > > > > > http://www.cs.dartmouth.edu/~doug/
> > > > > > > > 
> > > > > > > > It is basically an LCS diff algorithm implemented in C on top 
> > > > > > > > of Tcl's API,
> > > > > > > > thus giving full Unicode and VFS support.
> > > > > > > > 
> > > > > > > > 
> > > > > > > > OK?
> > > 
> > > Hey Stuart,
> > > 
> > > I use Tcl regularly so I thought I should give this a test for you.
> > > The port builds/packages fine here on amd64.  The only thing portcheck
> > > complained about was line lengths on pkg/DESCR, so a 'fmt -w 72' is
> > > needed there.
> > > 
> > > I loaded the module in tclsh8.6 interpreter and tested that I could reach
> > > the commands it provides, all seems good. 
> > > 
> > > $ tclsh8.6
> > > % package require DiffUtil
> > > 0.4.0
> > > % DiffUtil::diffFiles
> > > wrong # args: should be "DiffUtil::diffFiles ?opts? file1 file2"
> > > % DiffUtil::diffStrings
> > > wrong # args: should be "DiffUtil::diffStrings ?opts? line1 line2"
> > > 
> > > Thanks for the port!
> > > -ryan
> >

Attachment: diffutiltcl-0.4.0-port.tar.gz
Description: application/gzip

Reply via email to