On 2018/03/09 20:08, Jasper Lievisse Adriaanse wrote: > On Sat, Mar 10, 2018 at 03:45:36AM +1100, Joel Sing wrote: > > > > - The -x flag was previously on by default, which makes builds incredibly > > noisy. I've turned this off, but enabled it if DEBUG is specified. > I'm not a fan of this part. For many other ports we explicitly instruct the > build > framework to show us the actual commands being executed, so I'd like it for go > to keep doing this.
I agree, having build command lines in bulk build logs has been invaluable in the past and we generally enable them in other ports. On the other hand I realise it can make it harder to spot warnings in build output when building things by hand and I wouldn't mind having it controllable via a mk.conf "user settings" variable. Not necessarily specific to Go, this could be used in other places too. Something like a "PORTS_QUIETBUILD = Yes" variable perhaps? I wouldn't expect it to ever be supported everywhere nor would I want to see patches to upstream files just for this, but where there's a simple quiet/noisy flag (V=1 or --disable-silent-rules) it could be controlled by this.
