On 2018/04/10 10:02, Julien Dhaille wrote:
> Thank you for the review Landry !
> Fixed as suggested.
> 

Here's a diff on top to reorder Makefile more in-line with
Makefile.template, and provide COMMENT/DESCR that make a bit more
sense.. I'm OK with this version.



diff --git Makefile Makefile
index 2ec1fa8..d8a8d20 100644
--- Makefile
+++ Makefile
@@ -1,17 +1,21 @@
 # $OpenBSD$
 
-COMMENT=       Decrypting the output from the yubikey token
+COMMENT=       decrypt one-time-password for a YubiKey
 
 DISTNAME=      Auth-Yubikey_Decrypter-0.07
-MAINTAINER=    Julien Dhaille <jul...@dhaille.com>
+
 CATEGORIES=    security
+
+MAINTAINER=    Julien Dhaille <jul...@dhaille.com>
+
 PKG_ARCH=      *
 
 # Perl
-CPAN_AUTHOR=   MASSYN
 PERMIT_PACKAGE_CDROM=  Yes
 
 MODULES=       cpan
+CPAN_AUTHOR=   MASSYN
+
 RUN_DEPENDS=   security/p5-Crypt-Rijndael
 
 .include <bsd.port.mk>
diff --git pkg/DESCR pkg/DESCR
index 482f046..d07cad3 100644
--- pkg/DESCR
+++ pkg/DESCR
@@ -1,10 +1,4 @@
-Decrypt the output from the yubikey token
-
-The hardware can be found at http://www.yubico.com/home/index/
-
-The decryption module does only one thing - decrypt the AES encrypted
-OTP from the Yubikey. To this, it requires the OTP, and the AES key.
-
-Please note - this module does not perform authentication - it is
-a required component to decrypt the token first before authentication
-can be performed.
+Perl module that accepts an AES key and an encrypted one-time password
+generated by a Yubikey device, and returns a decrypted authentication
+token. For use in conjunction with other software that handles actual
+authentication.

Reply via email to