Anthony J. Bentley wrote on Tue, Apr 10, 2018 at 11:42:03PM -0600:
> Currently canna installs formatted English manuals (generated with groff)
> and formatted Japanese/EUC-JP manuals (generated with jgroff).
> Here's a diff that installs unformatted English manuals, unformatted
> Japanese/UTF-8 manuals, and formatted Japanese/EUC-JP manuals (generated
> with nkf+mandoc).
Even though installing anything into /usr/local/man/ja_JP.EUC/
violates the basic policy outlined on
below "Non-English manual pages", keeping them until somebody comes
round to check whether it still makes sense seems acceptable, if
espie@ specifically requests that, even though i would really prefer
to stop installing anything non-UTF-8 on OpenBSD. So it would be
quite welcome if somebody understanding these matters could check.
> You can view the formatted pages in kterm the same way as before:
> PAGER=jless LESSCHARSET=euc man -M /usr/local/man/ja_JP.EUC ...
> And the unformatted pages in a UTF-8 xterm with:
> man -M /usr/local/man/ja ...
Confirmed, though i can't check whether the rendering of the Japanese
text is actually correct.
In the Makefile below "post-install:", i'd suggest using
It ought to do the same and is shorter, more explicit, and hence
easier to understand and more robust.
In patches/patch-Canna_conf, are you sure that this part is still
+#define JNeqnCmd jneqn -Tnippon
+#define JNroffCmd jnroff -Tnippon
+#define JEqnCmd jeqn -Tnippon -Tps
+#define JTroffCmd jgroff -Tnippon -Tps
+#define JColCmd cat
+#define JTblCmd jtbl -Tnippon
+ JTROFF = JTroffCmd
+ JNROFF = JNroffCmd
+ JTBL = JTblCmd
+ JEQN = JEqnCmd
+ JNEQN = JNeqnCmd
+ JCOL = JColCmd
It doesn't seem to do harm, but it may be obsolete.
I failed trying to understand what the imake stuff is doing,
but the end result appears to be what we want.
You might wish to re-run "make update-plist" before commit, it
does a few cleanups:
* in PLIST-main:
which seems required
because these are not in /etc/mtree/4.4BSD.dist
- move man/man3/*.3 after man/ja_JP.EUC/*
* in PLIST-server:
- missing @bin before bin/cannaserver
- move man/man1/*.1 to the end (alphabet)
* in PLIST_dict:
- drop canna/group/ and canna/user/ which do not exist in
(By the way, -dict installing to /var/dict/canna/canna/
seems very messy, but that is unrelated to this patch.)
So, i agree with the general direction and think you should
go ahead if nobody objects.
> Index: Makefile
> RCS file: /cvs/ports/japanese/canna/Makefile,v
> retrieving revision 1.39
> diff -u -p -r1.39 Makefile
> --- Makefile 14 May 2017 19:53:58 -0000 1.39
> +++ Makefile 11 Apr 2018 05:34:45 -0000
> @@ -10,9 +10,9 @@ PKGNAME-main= cannalib-3.5b2
> PKGNAME-dict= cannadict-3.5b2
> PKGNAME-server= cannaserver-3.5b2
> -REVISION-main = 5
> +REVISION-main = 6
> REVISION-dict = 0
> -REVISION-server = 7
> +REVISION-server = 8