On Thu, Apr 12, 2018 at 08:18:54AM +0300, Kirill Bychkov wrote:

> >> > I'm not a fan of unnecessary flavours in ports, but I think this might
> >> > be a case where it makes sense?
> >>
> >> I would like it if there was a non-tokyo flavor. It has only ever
> >> caused problems for me. That said, I am not a very heavy user of it!
> >
> > I would suggest using a flavour to _enable_ tokyocabinet rather than
> > on-by-default. Maybe with a quick explanation why one might want to
> > use it in DESCR.
> >
> >
> Hi!
> Does it look good?

Looks good to me, with a small nitpick:

> -WANTLIB += GeoIP bz2 c ncursesw pthread tokyocabinet z
> +WANTLIB += GeoIP bz2 c curses pthread z

bz2 and z are only needed for the tokyocabinet flavor.

OK fcambus@ with this change. Thanks for taking care of it!

Reply via email to