On 2018/04/21 16:13, Matthieu Guegan wrote: > +HOMEPAGE = https://taskwarrior.org/ > +MASTER_SITES = ${HOMEPAGE}download/
we made a general decision to have MASTER_SITES stand alone some time ago rather than reference HOMEPAGE, i.e. please use MASTER_SITES = https://taskwarrior.org/download/ > +COMPILER = base-clang so this does need C++11, but I don't see why it would need to be clang. this line should probably be "base-clang ports-gcc". > +CONFIGURE_ARGS += -DCMAKE_BUILD_TYPE=release this is default, don't set it because it will do things wrong for builds done with MODCMAKE_DEBUG set (see cmake.port.mk). > +SEPARATE_BUILD = concurrent skip this line. not sure where it was copied it from, but concurrent was removed some time ago (and even when it was used, it was only for multi-flavour ports). SEPARATE_BUILD=Yes is set by default for cmake ports anyway as it's usually required. > +share/doc/timewarrior/ext/totals.py this has "#!/usr/bin/env python" which won't work. probably wants patching via MODPY_ADJ_FILES which will need MODULES=lang/python. if it doesn't warrant build/run deps then set MODPY_BUILDDEP=No MODPY_RUNDEP=No. pkg/DESCR is formatted a bit wide (hard against 80 columns). I think a quick reader may mistake Taskwarrior and Timewarrior in the text; maybe go for this instead? --- Timewarrior is a command line time tracking application, which allows you to record time spent on activities. It can be used as a companion program for Taskwarrior - a hook script provides integration with the matching start and stop commands, thereby enabling proper time tracking for Taskwarrior users. ---
