On 2018/04/22 15:54, manp...@gmail.com wrote:
> On 4/22/18 4:39 AM, manp...@gmail.com wrote:
> > On 4/15/18 1:25 PM, manp...@gmail.com wrote:
> > > The patch attached fixes building libtorrent-rasterbar on
> > > OpenBSD/Loongson for -rOPENBSD_6_3. It added several missing
> > > includes, added "-std=gnu++14" to CXXFLAGS as it is now default for
> > > newer compiler and the code uses those new features, and another
> > > patch from -current. I'm not sure whether this is the correct way to
> > > update ports for a -stable branch so let me know.
> > > 
> > > Thanks.
> > 
> > It seems that there is another problem with the setup.py of python
> > binding that relies on existence of environment variable CXX to be
> > defined, otherwise it will use "cc" instead of "c++" to build the
> > binding, which then lead to another problem: the main library would be
> > built using C++14 that enabled using std::chrono, while the bindings
> > would not and used boost::chrono instead, and the bindings will fail to
> > load due to missing symbols (actually symbol mismatch). The fix is to
> > define CXX=c++ in Makefile.am of python binding.
> > 
> > The revised patch against -rOPENBSD_6_3 is attached.
> 
> And it turns out it's a bad idea to patch configure.ac and Makefile.am which
> will require "autoreconf". Attaching the patch dropping those parts. 1.1.7
> on -current has similar issue and I'll provide a separate patch and also try
> to incorporate upstream.

No loongson here so I can't test any of this, but a few things:

- we work on -current primarily, sometimes things can be backported but if
this is broken on -current at the moment, that needs fixing first

- compilers should come from the environment rather than hardcoded, maybe
try something like:

MAKE_ENV =              CC="${CC}" CXX="${CXX}"
CXXFLAGS +=             --std=gnu++14

Reply via email to