On 2018/04/25 14:55, Solene Rapenne wrote: > > Jeremie Courreges-Anglas writes: > > > On Wed, Apr 25 2018, Solene Rapenne <[email protected]> wrote: > >> here is a port of py-pgpdump which is required for the port of > >> mail/mailpile which I'll submit soon. > >> > > - there's no actual dependency on security/pgpdump, this is really > > a python reimplementation, so we should remove security/pgpdump from > > BUILD/RUN_DEPENDS. I'd also suggest amending the COMMENT, something > > like "python binding for parsing PGP packets" > > I removed the BUILD and RUN depends and it still works correctly as > expected, I don't remember why I though it was needed. > > COMMENT is now "PGP packet parser library for Python" > > > - please make do-test depend on do-install instead of fake, so that > > ''make clean test'' works ootb. > > done > > > - please regen the PLIST (using the python3 FLAVOR), and fix the > > "duplicate item in packing-list" error by prefixing the offending line > > with ${MODPY_COMMENT} > > done > > > Also, I'm not sure it's worth patching out the failing test, I think > > it's clear from the error message that the issue is not a bug. Also if > > the next update adds the missing file, we'll have to remember to remove > > the patch or we'll miss a test. > > Indeed it's better to keep the failing test. So, I removed the patch and > added a comment in the Makefile to tell that the failure is known and > why. >
In DESCR you have, "A Python library for parsing PGP packets pgpdump binding for python, currently supports:" This reads a bit awkwardly, and I think it's really a separate implementation rather than a binding, perhaps this instead? "A Python library for parsing PGP packets, similar to the pgpdump utility. Currently supports:" Also please remove the blank line at end of DESCR. Otherwise OK sthen@
