On 2018/04/26 12:49, Klemens Nanni wrote: > On Thu, Apr 26, 2018 at 11:41:25AM +0100, Stuart Henderson wrote: > > Adding MAINTAINER to CC's. > > > > On 2018/04/26 12:07, Klemens Nanni wrote: > > > https://raw.githubusercontent.com/antirez/redis/4.0/00-RELEASENOTES > > > > > > Works and passes all tests on amd64. > > > > > > We can also keep the sources untouched as they won't be built anyway. > > > Plus, symlinks suffice here so avoid copying the rest. > > > > The 4.0.9 update part of the diff is ok with me, but actually rm'ing things > > seems safer , we don't really want a future update to accidentally enable > > jemalloc. > There's USE_JEMALLOC=no which I can pass. It's not done as of now since > MALLOC=libc is already the default. > > OK?
And if upstream changes something and the person updating the port doesn't notice, this may silently do nothing. We do *really* want things to be using system malloc. > Index: Makefile > =================================================================== > RCS file: /cvs/ports/databases/redis/Makefile,v > retrieving revision 1.102 > diff -u -p -r1.102 Makefile > --- Makefile 24 Apr 2018 14:35:29 -0000 1.102 > +++ Makefile 26 Apr 2018 10:48:42 -0000 > @@ -1,7 +1,7 @@ > # $OpenBSD: Makefile,v 1.102 2018/04/24 14:35:29 kn Exp $ > > COMMENT = persistent key-value database > -DISTNAME = redis-4.0.8 > +DISTNAME = redis-4.0.9 > CATEGORIES = databases > HOMEPAGE = https://redis.io/ > > @@ -20,6 +20,7 @@ MODULES = lang/lua \ > MAKE_FLAGS = CC="${CC}" \ > DEBUG="${DEBUG}" \ > DEBUG_FLAGS="${DEBUG}" \ > + USE_JEMALLOC=no \ > OPT="" \ > OPTIMIZATION="" \ > V=1 > @@ -39,11 +40,9 @@ DBDIR = ${VARBASE}/redis > SUBST_VARS += DBDIR > > pre-configure: > - cp ${WRKSRC}/deps/lua/src/fpconv.? ${WRKSRC}/src/ > - cp ${WRKSRC}/deps/lua/src/strbuf.? ${WRKSRC}/src/ > - cp ${WRKSRC}/deps/lua/src/lua_*.c ${WRKSRC}/src/ > - rm -rf ${WRKSRC}/deps/jemalloc > - rm -rf ${WRKSRC}/deps/lua > + ln -sf ${WRKSRC}/deps/lua/src/fpconv.? ${WRKSRC}/src/ > + ln -sf ${WRKSRC}/deps/lua/src/strbuf.? ${WRKSRC}/src/ > + ln -sf ${WRKSRC}/deps/lua/src/lua_*.c ${WRKSRC}/src/ > ${SUBST_CMD} ${WRKSRC}/src/Makefile > > post-install: > Index: distinfo > =================================================================== > RCS file: /cvs/ports/databases/redis/distinfo,v > retrieving revision 1.79 > diff -u -p -r1.79 distinfo > --- distinfo 19 Mar 2018 18:15:57 -0000 1.79 > +++ distinfo 26 Apr 2018 10:48:42 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (redis-4.0.8.tar.gz) = /ww4uMFWMZJJ/sYeUBjPW1/mOmW2FpC+x5j0yZjCMq0= > -SIZE (redis-4.0.8.tar.gz) = 1729973 > +SHA256 (redis-4.0.9.tar.gz) = 309zvDGOL5/7LRaaki3sV+x8c90HvM+HVpXb7s1exRA= > +SIZE (redis-4.0.9.tar.gz) = 1737022 >
