On 2018/04/28 00:07, Kaashif Hymabaccus wrote: > On Sat, Apr 14, 2018 at 01:03:09AM +0200, Klemens Nanni wrote: > > > > [...] > > > > Now that you're rolling your own do-install, this hunk is obsolete. > > > > [...] > > > > CC is already passed in MAKE_ENV, this can go, too. > > > > Addressed these comments. Also there was a hardcoded -Os in the CFLAGS > I patched out. > > I took out passing CC in MAKE_ENV since the farbfeld makefile is set > to use "cc" in config.mk, which is already linked to the right > compiler so there's no need to fix it.
Please don't rely on the cc wrapper. It's a hack for certain situations. Also it's easier to verify that a port does the right thing if CC is passed correctly.
