On Sun, May 06, 2018 at 03:34:20PM +0100, Stuart Henderson wrote: > > > Index: baresip/Makefile > > > =================================================================== > > > RCS file: /cvs/ports/telephony/baresip/baresip/Makefile,v > > > retrieving revision 1.20 > > > diff -u -p -r1.20 Makefile > > > --- baresip/Makefile 11 Mar 2018 18:48:59 -0000 1.20 > > > +++ baresip/Makefile 25 Apr 2018 15:50:36 -0000 > > > @@ -3,7 +3,7 @@ > > > COMMENT-main = modular SIP User-Agent with audio and video > > > support > > > COMMENT-gtk2 = GTK+2-based modules for baresip > > > > > > -V = 0.5.8 > > > +V = 0.5.9 > > > DISTNAME = baresip-$V > > > PKGNAME-main = baresip-$V > > > PKGNAME-gtk2 = baresip-gtk2-$V > > > @@ -14,7 +14,7 @@ WANTLIB-main += re rem sndfile sndio spa > > > WANTLIB-main += twolame v4l2 vpx x264 x265 > > > > > > WANTLIB-gtk2 += X11 Xcomposite Xcursor Xdamage Xext Xfixes Xi Xinerama > > > -WANTLIB-gtk2 += Xrandr Xrender atk-1.0 cairo fontconfig freetype > > > gdk-x11-2.0 > > > +WANTLIB-gtk2 += Xrandr Xrender atk-1.0 cairo fontconfig freetype fribidi > > > gdk-x11-2.0 > > > WANTLIB-gtk2 += gdk_pixbuf-2.0 gio-2.0 glib-2.0 gobject-2.0 gstapp-1.0 > > > WANTLIB-gtk2 += gstbase-1.0 gstreamer-1.0 gtk-x11-2.0 intl mpg123 > > > pango-1.0 > > > WANTLIB-gtk2 += pangocairo-1.0 pangoft2-1.0 re z > > > @@ -37,7 +37,8 @@ LIB_DEPENDS-main = audio/gsm \ > > > telephony/baresip/re>=0.5.7 \ > > > telephony/baresip/rem>=0.5.2 \ > > > telephony/spandsp > > > -LIB_DEPENDS-gtk2 = multimedia/gstreamer1/plugins-base \ > > > +LIB_DEPENDS-gtk2 = devel/fribidi \ > > I think fribidi should only be a WANTLIB (unless baresip started > using fribidi directly itself).
Indeed. Thanks for spotting! > Rest reads good, did you check the shared libraries for ABI changes to > identify whether bumps are needed? Yes, I checked them (both reading upstream change logs and using /usr/src/lib/check_sym). I assume after the fribidi LIB_DEPENDS removal this implies your OK? I'll commit the update in the next days under this assumption (or earlier with an explicit OK). Best regards, Ingo
