On 2018/06/06 17:48, Leonid Bobrov wrote:
> On Wed, Jun 06, 2018 at 03:17:32PM +0100, Stuart Henderson wrote:
> > Too soon for a mail that goes ping. It's not an urgent update,
> > and there are much older submissions than this that are still waiting.
> > 
> > Generally you can improve chances of diffs getting looked at more
> > quickly by getting the initial one as good as you can (read it through,
> > see if the changes make sense, do as much testing as possible before
> > sending to the list, etc).
> > 
> 
> I don't understand, all I did is:
> 
> * Test Minetest snapshots by playing before 0.4.17 release.
> * Update Makefile, make server build too.
> * Update distinfo.
> * Remove unnecessary and obsolete patches.
> * Update plist because some files appeared and some files are gone.
> 
> But I didn't test server part. So yeah, changes make sense.
> 

This is only 2 days after you sent your first diff and you're chasing up
for another response.

Unless somebody is particularly interested in that particular port or
there's an obvious problem with the diff that makes it easy to reply
quickly, that's way too soon. We don't operate on that sort of timescale,
and making more noise on the mailing lists does not help diffs get
reviewed quickly.

Then I am just giving a bit of advice to increase chances that when you send
diffs in future people are likely to look at them sooner - it took 3
diffs when you sent it to get past 1) something that you probably would
have spotted if you had read the diff you were sending, and 2) a problem
which you ran into yourself in testing after you sent the initial one.
If you are known for sending good sane diffs that don't require extra
work before commit, that increases the chances of them getting reviewed
quickly.


Reply via email to