Theo Buehler <[email protected]> wrote: > Been seeing a few of these lately: > > gimp: vfprintf %s NULL in "Bookmark '%s' cannot be removed" > pidgin: vfprintf %s NULL in "Bookmark '%s' cannot be removed" > > Patch below silences them. Not sure if the "Remove the bookmark" string > can be reached with name == NULL, but why not treat the two cases the > same way. > > + if (removable) > +- tip = g_strdup_printf (_("Remove the bookmark '%s'"), name); > ++ tip = g_strdup_printf (_("Remove the bookmark '%s'"), name ? name : > "(null)")
yuck. The passing of (null) is hiding an higher-level problem. How about reporting it to upstream instead?
