On 06/26/18 09:51, Stuart Henderson wrote:
ok with me (though I'd add a comment to the patch, just "fix arch where char are unsigned by default" or something)
Committed, thanks
On 2018/06/25 20:54, Matthew Martin wrote:I use neither ht nor aarch64, but [0] htcoffhd.cc:75:3: error: constant expression evaluates to -1 which cannot be narrowed to type 'char' [-Wc++11-narrowing] {-1, "COFF - file characteristics"}, ^~ seems straightforward to fix. Same fix was sent upstream[1]. I think the crank can be left out since the binary will be identical on signed char arches and fixes the build on unsigned char arches. - Matthew Martin 0: http://build-failures.rhaalovely.net//aarch64/2018-06-21/editors/ht.log 1: https://github.com/sebastianbiallas/ht/pull/21 diff --git patches/patch-httag_h patches/patch-httag_h new file mode 100644 index 00000000000..d4cc09d7f50 --- /dev/null +++ patches/patch-httag_h @@ -0,0 +1,14 @@ +$OpenBSD$ + +Index: httag.h +--- httag.h.orig ++++ httag.h +@@ -69,7 +69,7 @@ struct ht_tag_flags { + } PACKED; + + struct ht_tag_flags_s { +- char bitidx; ++ signed char bitidx; + const char *desc; + } PACKED; +
