On Thu, Jul 19, 2018 at 07:23:22PM +0200, Juan Francisco Cantero Hurtado wrote:
> On Thu, Jul 19, 2018 at 06:01:41PM +0200, Juan Francisco Cantero Hurtado 
> wrote:
> > On Thu, Jul 19, 2018 at 05:28:17PM +0200, Klemens Nanni wrote:
> > > On Thu, Jul 19, 2018 at 04:43:30PM +0200, Juan Francisco Cantero Hurtado 
> > > wrote:
> > > > I need the library for the upcoming nginx-modsecurity package.
> > > > C patches by robert@.
> > 
> > Thanks for the review.
> > 
> > > sparc64:
> > > 
> > >   cc1plus: error: unrecognized command line option "-std=c++11"
> > > 
> > 
> > I added COMPILER to the port.
Please add a "C++11" comment above.

> > > Lots of `-O3' as well, please get rid of these and ensure that *FLAGS
> > > get through.
> > 
> > I saw that but our flags are passed at the end and have priority over
> > O3. I just want to avoid the extra patches.
I'm not fond of depending on this, but don't want to bikeshed over it,
either.

> And new tarball with configure args splitted. Sorry for the double
> posting.
Still squashed. I'd also split CONFIURE_ENV; it's in most of our ports
and improves readability.

WANTLIB seems to miss `pcre'.

Reply via email to