On 2018/08/28 16:41, Elias M. Mariani wrote:
> The thing is that is not a ipython -> ipython-docs problem, is:
> ipython -> ipykernel -> ipython-docs.
> Because ipykernel needs ipython as a RUN_DEPENDS and ipython-docs
> needs ipykernel as a BUILD_DEPENDS.
> It working now because ipykernel is missing the RUN_DEPENDS on ipython.
>
> 2018-08-28 16:32 GMT-03:00 Stuart Henderson <[email protected]>:
> > On 2018/08/28 16:11, Elias M. Mariani wrote:
> >> I think the same, the only issue is that we usually make devel/ipython
> >> to have a RUN_DEPENDS=devel/ipython-docs, in this case we can not do
> >> that. Probably the docs will get never pulled, so... Is it necessary
> >> to leave them there ? Maybe adding https://ipython.readthedocs.io to
> >> the DESCR and stop building the docs ?
> >>
> >> 2018-08-28 16:04 GMT-03:00 Stuart Henderson <[email protected]>:
> >> > On 2018/08/28 15:56, Elias M. Mariani wrote:
> >> >> Sorry to bother but I would like the opinions of Stuart and Edd on how
> >> >> to proceed.
> >> >>
> >> >> Cheers.
> >> >> Elias.
> >> >>
> >> >> 2018-08-25 15:20 GMT-03:00 Elias M. Mariani <[email protected]>:
> >> >> > I detected the following error in the dependencies of this ports:
> >> >> >
> >> >> > devel/ipython has a dependency on devel/py-ipykernel, but is only used
> >> >> > to build the docs.
> >> >> > https://github.com/ipython/ipython/blob/5.8.0/docs/autogen_config.py#L6
> >> >> >
> >> >> > devel/py-ipykernel should have a run dependency on devel/ipython,
> >> >> > witch is not specified right now.
> >> >> > https://github.com/ipython/ipykernel/blob/4.8.2/setup.py#L84
> >> >> >
> >> >> > This would create a circular dependency.
> >> >> > Of couse, the correct path would be:
> >> >> > - build ipython
> >> >> > - build ipykernel (depends on ipython)
> >> >> > - build ipython-docs (depends on ipython and ipykernel)
> >> >> >
> >> >> > But I would need to create devel/ipython-docs to be built separately
> >> >> > from devel/ipython.
> >> >> > Another positive side is that this would make a single doc folder if
> >> >> > one needs the python3 and python2 version of ipython.
> >> >> >
> >> >> > Any issues or recommendations ?
> >> >> >
> >> >> > Cheers.
> >> >> > Elias.
> >> >
> >> > Splitting off to devel/ipython-docs sounds sane to me.
> >> >
> >
> > These docs seem like something that might possibly be useful on a
> > non-internet-connected machine, if it's not too tricky to do then I
> > think it makes sense to provide them.
> >
> > Can you do this with "BUILD_DEPENDS= devel/ipython:build" in an
> > ipython-docs port, and then use a custom do-build pointing at this
> > directory? That way devel/ipython doesn't need to actually be
> > *installed* during ipython-docs build, so you could still list
> > ipython-docs as a RUN_DEPENDS.
> >
> > Running sphinx is actually quite slow for this, so splitting this
> > (stop building docs in ipython itself, only build docs once) should
> > save time overall.
> >
Ah I see. Is there anything you can do with this (moving things into
place after the dependencies are built under ipython-docs work directory)?
BUILD_DEPENDS= devel/ipython:build \
devel/ipykernel:build
If not then probably best to skip the RUN_DEPENDS on ipython-docs.
