Jeremie Courreges-Anglas <[email protected]> wrote: > On Thu, Aug 30 2018, Jeremie Courreges-Anglas <[email protected]> wrote: > > On Thu, Aug 30 2018, Solene Rapenne <[email protected]> wrote: > >> Solene Rapenne <[email protected]> wrote: > >>> The 0.3.7 version has been released in 2012, it's time to update the > >>> port... The version seems to be code cleanup and adding asin and acos > >>> function. > >>> > >>> Examples provided seems to work. > >>> > >>> Index: Makefile > >>> =================================================================== > >>> RCS file: /cvs/ports/graphics/sketch/Makefile,v > >>> retrieving revision 1.2 > >>> diff -u -p -r1.2 Makefile > >>> --- Makefile 11 Mar 2013 11:10:55 -0000 1.2 > >>> +++ Makefile 10 Aug 2018 22:26:03 -0000 > >>> @@ -2,7 +2,7 @@ > >>> > >>> COMMENT = 3D scene description translator for TeX > >>> > >>> -DISTNAME = sketch-0.3.2 > >>> +DISTNAME = sketch-0.3.7 > >>> EXTRACT_SUFX = .tgz > >>> > >>> CATEGORIES = graphics > >>> Index: distinfo > >>> =================================================================== > >>> RCS file: /cvs/ports/graphics/sketch/distinfo,v > >>> retrieving revision 1.2 > >>> diff -u -p -r1.2 distinfo > >>> --- distinfo 18 Jan 2015 03:14:14 -0000 1.2 > >>> +++ distinfo 10 Aug 2018 22:26:03 -0000 > >>> @@ -1,2 +1,2 @@ > >>> -SHA256 (sketch-0.3.2.tgz) = 9vyJH881KEwBiqZ4a69nQpSU90mcUzt5AbDnQbKo5S8= > >>> -SIZE (sketch-0.3.2.tgz) = 2881333 > >>> +SHA256 (sketch-0.3.7.tgz) = EpYq1f5aD3yfxthL1NCbh5u/YEl1yDlAXxYTvmV7qAQ= > >>> +SIZE (sketch-0.3.7.tgz) = 2882384 > >> > >> ping? > > > > Woops, this one fell through the cracks (same for your minecraft > > update). > > > > The update LGTM, ok jca@. The warnings are scary, though. > > Build-tested only. > > > Index: patches/patch-geometry_c > =================================================================== > RCS file: patches/patch-geometry_c > diff -N patches/patch-geometry_c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ patches/patch-geometry_c 30 Aug 2018 16:18:09 -0000 > @@ -0,0 +1,14 @@ > +$OpenBSD$ > + > +Index: geometry.c > +--- geometry.c.orig > ++++ geometry.c > +@@ -615,7 +615,7 @@ int boxes_2d_intersect_p(BOX_2D * a, BOX_2D * b) > + return 1; > + } > + > +-int boxes_3d_intersect_p(BOX_2D * a, BOX_2D * b) > ++int boxes_3d_intersect_p(BOX_3D * a, BOX_3D * b) > + { > + if (a->max[X] < b->min[X]) // a left of b > + return 0; > Index: patches/patch-geometry_h > =================================================================== > RCS file: patches/patch-geometry_h > diff -N patches/patch-geometry_h > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ patches/patch-geometry_h 30 Aug 2018 16:19:08 -0000 > @@ -0,0 +1,14 @@ > +$OpenBSD$ > + > +Index: geometry.h > +--- geometry.h.orig > ++++ geometry.h > +@@ -237,7 +237,7 @@ void fold_min_max_polyline_3d(BOX_3D * b, POLYLINE_3D > + void copy_box_2d(BOX_2D * r, BOX_2D * s); > + void copy_box_3d(BOX_3D * r, BOX_3D * s); > + int boxes_2d_intersect_p(BOX_2D * a, BOX_2D * b); > +-int boxes_3d_intersect_p(BOX_2D * a, BOX_2D * b); > ++int boxes_3d_intersect_p(BOX_3D * a, BOX_3D * b); > + > + // ---- transformations > -------------------------------------------------------- > +
I commited the update with your patches. I tried with/without the patches to run the examples and making the rendering with latex and I did not see any differences.
