On Sun, Sep 02, 2018 at 04:35:12PM -0700, Ayaka Koshibe wrote:
> Thanks, will fix it but won't trouble the list with the giant diff again...
Sure.

> > Does Python 3 work or is Python 2 required? That's stuff for a separate
> > diff but I prefer ports to make it more obvious why a particular version
> > was chosen.
> 
> It requires Python 2. Should this be indicated somewhere e.g. in a comment?
Just set `MODPY_VERSION = ${MODPY_DEFAULT_VERSION_2}' explicitly instead
of relying on it as module default, optionally with a comment above
stating why Python 3 does not work so porters can start right there or
avoid trying it in the first place.

Reply via email to