On Mon, Oct 22, 2018 at 06:12:00PM -0000, Christian Weisgerber wrote:
> On 2018-10-22, Marc Espie <es...@nerim.net> wrote:
> 
> > There are some technical reasons to put a space before the =, because
> > it DOES let things be unambiguous for make.
> >
> > (say, if S=-c++,  PKGNAME${S}=somevalue  will NOT do what you expect)
> 
> That construct is exceedingly rare in port Makefiles.
> In fact, I can't find a single example outside of bsd.port.mk.
> 
> And it would be more reasonable not to permit characters like '+'
> in variable names in the first place.

Doesn't change the fact that I *have* to be careful in bsd.port.mk,
thus I've more or less programmed my fingers to put spaces around = signs.

Note that this is also the same style in C.

I really have to force myself to not put spaces before = in any kind of
assignment, and it still looks bizarre to me.

Reply via email to