On Sun, Oct 21, 2018 at 01:16:56PM -0700, Andrew Hewus Fresh wrote:
> On Sun, Oct 21, 2018 at 04:05:48AM +0000, wen heping wrote:
> >     Here is a patch to update :
> >          devel/p5-Test-Base --> 0.89
> 
> I think this needs a new TEST_DEPENDS of p5-Algorithm-Diff, see below

OK bluhm@

> >          devel/p5-Test-YAML --> 1.07
> 
> OK afresh1@

This needs p5-Test-Pod>=1.41.
OK bluhm@, please commit after p5-Test-Base is in

> >          devel/p5-YAML --> 1.26
> 
> This needed some TEST_DEPENDS fixes for me, see below

This needs p5-Test-Pod>=1.41.
OK bluhm@

> >          devel/p5-YAML-Tiny --> 1.73
> 
> Looks like most of the test depends moved to the xt/ directory so we
> don't need them, but it did need p5-JSON-MaybeXS, see below.

Please remove the AUTOMATED_TESTING=1 line.  The test that evaluated
it, has been removed upstream.
OK bluhm@

> >          devel/p5-YAML-XS --> 0.74
> 
> OK afresh1@
> (and I can take MAINTAINER on it, as I'm already p5-YAML)

I have commited this.

> +TEST_ENV +=    AUTHOR_TESTING=1

In general I don't like += if it does not change a previous setting.
Just use = instead.

bluhm

Reply via email to