On 2018/10/25 20:33, Klemens Nanni wrote:
> On Thu, Oct 25, 2018 at 09:43:02AM -0700, Heppler, J. Scott wrote:
> > Upstream tagged 1.4 and I'm still struggling with the python3 rdep.
> >
> > MODULES= lang/python
> > MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
> >
> > stops "make build" with the error: can't find ./setup.py
> >
> > No setup.py exists in the upstream code.
> See port-modules(5) where MODPY_SETUPTOOLS is documented.
>
> > python3 is not a build dependency and is only needed if
> > "jgmenurc pmenu" is invoked.
> > https://github.com/johanmalm/jgmenu/blob/master/INSTALL.md#dependencies
> MODPY_BUILDDEP
>
> > Johan Malm tells me that python3 is just used to produce text output.
> >
> > My understanding is that "MODULES" appends to BUILD_DEPENDS,
> > RUN_DEPENDS, LIB_DEPENDS and WANTLIB but for this port only RUN_DEPENDS
> > is needed. Would the most concise way to deal with the RUN_DEPENDS be
> > to fully specify lang/python3 in RUN_DEPENDS. I've looked at other
> > recent, python based ports and have not found a similar, python3
> > RUN_DEPENDS. The closest seems to be productivity/calcurse.
> >
> > Or use MODULES and disable the appending of BUILD_DEPENDS, LIB_DEPENDS
> > and WANTLIB?
> >
> > What I have currently:
> >
> > # $OpenBSD: Makefile.template,v 1.78 2018/07/09 15:00:06 jca Exp $
> >
> > COMMENT= freedesktop-complaint menu for openbox and tint2
> >
> > V= 1.4
> > CATEGORIES= x11
> > DISTNAME= jgmenu-${V}
> > HOMEPAGE= https://github.com/johanmalm/jgmenu
> > GH_ACCOUNT= johanmalm
> > GH_PROJECT= jgmenu
> Just set GH_TAG=v1.4 instead of V, HOMEPAGE and MASTER_SITES.
>
Oh yes I missed that. It's GH_TAGNAME though, and here it will also replace
DISTNAME.
