On Mon, Nov 12, 2018 at 04:42:42PM +0100, Jeremie Courreges-Anglas wrote:
> On Mon, Nov 12 2018, Sebastien Marie <[email protected]> wrote:
> > Hi,
> >
> > I would like py-phonenumbers to be imported.
> >
> > It is a library to manipulate phone numbers.
> >
> > This is a Python port of Google's libphonenumber library (original code
> > in Java).
> >
> > The main object that the library deals with is a PhoneNumber object.
> >
> > - phone number validation: possible or valid (assigned exchange) number
> > - format it in a standardized format a phone number
> > - get some information about the location that corresponds to a phone
> > number
> > - find out information about which carrier originally owned a phone
> > number
> >
> > https://github.com/daviddrysdale/python-phonenumbers
>
> Looks mostly good, except:
> - s/Google s/Google's/ in COMMENT; I guess you tried to avoid breaking
> syntax hilighting
yes, it was a try to avoid the "'"
> - doesn't package with default python2 FLAVOR, needs ${MODPY_COMMENT}
oops. I am using it with py3. sorry about that
> - portcheck warns about DESCR
>
> Here's an updated tarball that fixes the above points and tweaks DESCR
> to read nicer and shorter. I also think this should go in telephony/
> instead of devel/, I've kept devel in CATEGORIES in case you care.
no problem for me about the category.
> Looks ready to import to me. :)
thanks for your fixes :)
--
Sebastien Marie
