On Sun, Nov 25, 2018 at 06:49:43AM -0600, Edward Lopez-Acosta wrote:
> Hi Sebastien,
> 
> Thank you for the tips.

some nits

> I think the CONFIGURE_STYLE removal was simply an oversight on my part.

no problem.

> I regened the list of crates using the method you noted (which was
> quite handy, and there were a lot of changes),

you removed tabs and inserted spaces. it is why there is still lot of changes.

>  and removed WANTLIB since this
> version removes pledge for the time being.

well, only the comment should be removed, not WANTLIB :)

see bsd.port.mk(5) man page, specially 'port-lib-depends-check' entry.

$ make port-lib-depends-check
...

> I am still interested in where this gets applied if it gets added for
> a revision.

I will look to re-add it later. Having some example code in Rust is a good
thing.

> New diff attached using a tip (on another port) from Stuart Henderson. It
> should hopefully be easier to apply now. I used `git diff --relative .` in
> the port directory rather than from /usr/ports and specifying the port.
> 
> All tests pass and builds/runs fine on amd64.
> 
> Thank you.
> 
> Edward Lopez-Acosta
> 

Thanks.
-- 
Sebastien Marie

Reply via email to