On Sun, Nov 25, 2018 at 02:19:01PM -0500, Daniel Jakots wrote:
> On Thu, 28 Jun 2018 15:27:04 +0100, Stuart Henderson
> <[email protected]> wrote:
> 
> > @pkgpath devel/py-libmagic${MODPY_FLAVOR}
> 
> This doesn't work.
> If I have @pkgpath devel/py-libmagic, only py2 gets updated. If I have
> @pkgpath devel/py-libmagic${MODPY_FLAVOR}, none gets updated.
> In order to test, I put
> @pkgpath devel/py-libmagic
> @pkgpath devel/py-libmagic,python3
> 
> and pkg_add updated both:
> py-libmagic-5.34->py-magic-0.4.15v0: ok
> py3-libmagic-5.34->py3-magic-0.4.15v0: ok
> 
> The only other python port that has something like that is
> py-sqlalchemy and it has what sthen said:
> @pkgpath databases/py-sqlalchemy${MODPY_FLAVOR}
> 
> Any idea?

with "@pkgpath devel/py-libmagic${MODPY_FLAVOR}" in pkg/PLIST, the
+CONTENTS file has "${MODPY_FLAVOR}" verbatim in it. so the variable
isn't substituted. I am unsure if it is expected or not.

espie@, could you comment on it ? the purpose is to have two migration
paths for:

- devel/py-libmagic -> devel/py-magic
- devel/py-libmagic,python3 -> devel/py-magic,python3

please note it seems incorrect to me to have both lines ("@pkgpath
py" and "@pkgpath py3") as the two versions still exists and could be
installed separately.

> I attached the py-magic port and the quirks diff I currently have.
> 
> Cheers,
> Daniel

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/quirks/Makefile,v
> retrieving revision 1.647
> diff -u -p -r1.647 Makefile
> --- Makefile  20 Nov 2018 17:35:16 -0000      1.647
> +++ Makefile  25 Nov 2018 19:16:19 -0000
> @@ -5,7 +5,7 @@ CATEGORIES =  devel databases
>  DISTFILES =
>  
>  # API.rev
> -PKGNAME =    quirks-3.40
> +PKGNAME =    quirks-3.41
>  PKG_ARCH =   *
>  MAINTAINER = Marc Espie <[email protected]>
>  
> Index: files/Quirks.pm
> ===================================================================
> RCS file: /cvs/ports/devel/quirks/files/Quirks.pm,v
> retrieving revision 1.661
> diff -u -p -r1.661 Quirks.pm
> --- files/Quirks.pm   20 Nov 2018 17:35:16 -0000      1.661
> +++ files/Quirks.pm   25 Nov 2018 19:16:19 -0000
> @@ -285,6 +285,8 @@ my $stem_extensions = {
>  # 6.5
>       'ValyriaTear' => 'valyriatear',
>       'apertium-es-ast_NO-PN' => 'apertium-es-ast',
> +     'py-libmagic' => 'py-magic',
> +     'py3-libmagic' => 'py3-magic',
>  };
>  
>  my $obsolete_reason = {

Thanks.
-- 
Sebastien Marie

Reply via email to