On Fri, Dec 07 2018, Sebastien Marie <[email protected]> wrote:
> On Fri, Dec 07, 2018 at 06:23:33AM +0100, Sebastien Marie wrote:
>> On Wed, Dec 05, 2018 at 05:03:14PM +0100, Sebastien Marie wrote:
>> > Hi,
>> >
>> > devel/llvm,-python provides a lldb python module. The module used a
>> > _lldb.so module, which is in fact a symlink to liblldb.so (installed in
>> > /usr/local/lib).
>> >
>> > Below an untested diff to correct the symlink in post-install. I will
>> > test it soon.
>>
>> After testing, it seems my diff was wrong. so a new diff (tested this
>> time).
>>
>
> And updated diff after latest changes in devel/llvm.
>
> Comments or OK ?
- LOCALBASE is "where other ports have been installed". You should use
TRUEPREFIX.
- the command will fail if lldb isn't built, so you need to make it
conditional.
Revised diff below tested on amd64, my sparc64 is MIA at the moment but
the logic should be fine. If you agree with that diff, ok jca@
Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/llvm/Makefile,v
retrieving revision 1.200
diff -u -p -r1.200 Makefile
--- Makefile 6 Dec 2018 21:51:01 -0000 1.200
+++ Makefile 6 Dec 2018 22:16:24 -0000
@@ -22,6 +22,7 @@ PKGNAME-python = py-llvm-${LLVM_V}
PKGNAME-lldb = lldb-${LLVM_V}
REVISION-main = 19
REVISION-python = 3
+REVISION-lldb = 0
CATEGORIES = devel
DISTFILES = llvm-${LLVM_V}.src${EXTRACT_SUFX} \
cfe-${LLVM_V}.src${EXTRACT_SUFX} \
@@ -141,6 +142,10 @@ post-install:
# lit and FileCheck are not installed
@rm ${PREFIX}/man/man1/lit.1
@rm ${PREFIX}/man/man1/FileCheck.1
+.if ${BUILD_PACKAGES:M-lldb}
+ ln -fs ${TRUEPREFIX}/lib/liblldb.so.${LIBlldb_VERSION} \
+ ${PREFIX}/lib/python${MODPY_VERSION}/site-packages/lldb/_lldb.so
+.endif
.include <bsd.port.mk>
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
