On 2018/12/12 14:45, Kirill Bychkov wrote: > On Wed, December 12, 2018 14:08, Stuart Henderson wrote: > > On 2018/12/12 14:02, Kirill Bychkov wrote: > >> On Wed, December 12, 2018 13:07, Kirill Bychkov wrote: > >> > On Tue, December 11, 2018 13:40, Stuart Henderson wrote: > >> >> On 2018/12/11 18:47, YASUOKA Masahiko wrote: > >> >>> Hi, > >> >>> > >> >>> The diff does the followings: > >> >>> > >> >>> - update to jansson-2.12 > >> >>> - include a static library > >> >>> - use configure && make, instead of cmake > >> >>> > >> >>> My motivation was to include the static library, since I'd like to use > >> >>> it within a statically linked CGI program. > >> >>> > >> >>> I had tried to modify CMakeLists.txt to build both static and shared > >> >>> library, but it was not easy for me. On the other hand, just doing > >> >>> "configure && make" does it as the default. I choiced "configure" > >> >>> rather than cmake. Is there any reason to keep using cmake? > >> >> > >> >> It needs testing with dependent ports either way, but the static > >> >> library can be added to the cmake build like this: > >> >> > >> >> Index: Makefile > >> > > >> > [...] > >> > > >> >> > >> > > >> > Hi! > >> > Thanks for the diff needed to build static libs alogside shared one. > >> > I think we could add it without updating jansson itself at this moment. > >> > Update will follow after testing dependent ports. > >> > > >> > > >> Forgot to add diff > > > > There isn't much of concern in the 2.11->2.12 update, I'm partway through > > a build test of dependent ports with my 2.12 diff at the moment. > > > > > Great. If it doesn't break anything, I'm OK with your patch. >
Thanks, tests look good so I have committed.
