On 2018/12/17 01:50, Jeremie Courreges-Anglas wrote: > On Sun, Dec 16 2018, Stuart Henderson <[email protected]> wrote: > > Unbound in base only includes the programs (daemon and tools). > > > > I will be wanting the library for an Asterisk update, thfr@ was > > interested in it a little while ago, and florian@ expressed an > > interest too. > > > > Currently it feels like ports is the best place for this, so > > here's a proposed port. > > I see no reason to adds this to base. The obvious risk with > a libunbound port is about base unbound and this port getting out of > sync, but I'm not even sure that's a problem.
Yes, agreed - I would plan to keep them synced anyway but don't think it's a problem. > > Any comments/OKs? > > LGTM > > I noticed that the Makefile specifies --with-libexpat=/usr even though > expat doesn't appear in WANTLIB; but that's not necessarily a problem. It's just used for unbound-anchor, not really necessary to specify in the port, but I'd prefer to keep configure flags in sync with base. > pkg/DESCR says: > This package contains the validating resolver library from the Unbound > distribution (the main Unbound resolver is OpenBSD's base OS). > > Maybe s/is/in/? Thanks, I added a couple more words "(the main Unbound resolver daemon and tools are in OpenBSD's base OS)". > Otherwise ok jca@ > > -- > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE > Thanks for the review.
