On Tue, Jan 01, 2019 at 02:01:32AM +0100, Klemens Nanni wrote:
> On Mon, Dec 31, 2018 at 04:59:57PM -0500, Eric Radman wrote:
> > Yes, this update is good.
> Cool.
>
> New diff that
>
> * drops default TEST_TARGET
> * drops REV in favour of globbing, making updates simpler
> * break MAKE_FLAGS into one assignment per line
>
> OK?

Good additions! I'll make sure to follow them on my next submission.
(no OK since I'm not a committer)

>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/sysutils/entr/Makefile,v
> retrieving revision 1.12
> diff -u -p -r1.12 Makefile
> --- Makefile  20 Feb 2018 19:23:34 -0000      1.12
> +++ Makefile  1 Jan 2019 00:58:29 -0000
> @@ -2,8 +2,7 @@
>
>  COMMENT =    run arbitrary commands when files change
>
> -DISTNAME =   entr-4.0
> -REV =                d5110481f5b9
> +DISTNAME =   entr-4.1
>
>  CATEGORIES = sysutils
>
> @@ -20,10 +19,9 @@ MASTER_SITES =     http://entrproject.org/co
>               https://bitbucket.org/eradman/entr/get/
>
>  MAKE_FILE =  Makefile.bsd
> -MAKE_FLAGS = CC="${CC}" LDFLAGS="${LDFLAGS}"
> -WRKDIST =    ${WRKDIR}/eradman-entr-${REV}
> +MAKE_FLAGS = CC="${CC}" \
> +             LDFLAGS="${LDFLAGS}"
> +WRKDIST =    ${WRKDIR}/eradman-entr-*
>  FAKE_FLAGS = DESTDIR=""
> -
> -TEST_TARGET =        test
>
>  .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/sysutils/entr/distinfo,v
> retrieving revision 1.9
> diff -u -p -r1.9 distinfo
> --- distinfo  20 Feb 2018 19:23:34 -0000      1.9
> +++ distinfo  31 Dec 2018 22:02:09 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (entr-4.0.tar.gz) = StT+kQixeRmZUc/HilgaimlgKwc9rlm8rkuBD24fbIs=
> -SIZE (entr-4.0.tar.gz) = 24758
> +SHA256 (entr-4.1.tar.gz) = xQPJPM/8HmstqXnNy4jFpobiYRA1Ae7ecHf6CJzf73g=
> +SIZE (entr-4.1.tar.gz) = 25265
>

--
Sascha Paunovic <azarus>

Reply via email to