On Wed, Jan 02, 2019 at 11:41:46AM +0100, Rafael Sadowski wrote:
> ... but that's to long
?

> -                     SHFLAGS="-shared"  CXX=${CXX}
> +                     SHFLAGS="-shared" CXX=${CXX}
Just break it:
                        SHFLAGS="-shared" \
                        CXX=${CXX}

> +post-install:
> +     ${INSTALL_MAN} ${WRKSRC}/docs/melt.1 ${PREFIX}/man/man1/
Please add the target further down above/below `do-test', not between
variable assignments here.

        # LFLAGS is not a typo
        TEST_ENV =›     ›       COPTS="${CXXFLAGS}" LFLAGS="${LDFLAGS} -pthread"
        do-test:

You might as well break TEST_ENV between COPTS and LFLAGS and insert
an empty line above do-test, but I'll stop with nit-picking here.

OK kn with or without this.

Reply via email to