On 2019/01/03 11:37, Landry Breuil wrote:
> On Thu, Jan 03, 2019 at 07:23:57PM +0900, SASANO Takayoshi wrote:
> > Hi,
> >
> > here is second edition,
> >
> > > Some notes:
> > > - patches should be generated with make update-patches, which puts the
> > > $OpenBSD$ cvs ids on top.
> > > - msdl-1.2.7-r2 as a version doesnt conform to packages-specs(7),
> > > msdl-1.2.7pl2 might be better.
> >
> > add $OpenBSD$ id to patches, and package name is msdl-1.2.7p2 instead of
> > msdl-1.2.7-r2.
>
> That's not a big deal, but here upstream released msdl-1.2.7,
> msdl-1.2.7-r1 and msdl-1.2.7-r2 where to me 'r' means 'patch levels on top of
> 1.2.7', and thus the use of the 'pl' prefix is appropriate here. using
> just 'p' means 'openbsd packaging patch level/revision' which isnt
> really the case...
>
> Landry
>
I would suggest this:
V = 1.2.7
DISTNAME = msdl-1.2.7-r2
PKGNAME = ${DISTNAME:S/-r/pl}
REVISION can only be used for revisions of the port.
