Hi Stuart, Jeremie,
thanks for your input, I'll look into all of it a.s.a.p. and send updated patch.
cheers,
Sebastian
Am Montag, Januar 28, 2019 17:56 CET, Stuart Henderson <s...@spacehopper.org>
schrieb:
> On 2019/01/28 16:27, Jeremie Courreges-Anglas wrote:
> > On Mon, Jan 28 2019, "Sebastian Reitenbach" <sebas...@l00-bugdead-prods.de>
> > wrote:
> > > Hi,
> > >
> > > this updates the quite outdated aircrack-ng to currrent 1.5.2 release.
> > > Tested on i386 with rum(4) interface, save captures with airodump,
> > > deauth a couple of clients, wordlist cracking with aircrack-ng.
>
> This could use tests on a wider range of interfaces.
>
> > > USE_GMAKE= Yes
> > > +USE_LIBTOOL= gnu
>
> I'd like to see an explanatory comment next to any USE_LIBTOOL=gnu ..
> (or even better a fix to avoid the need).
>
> If this is *only* needed for libtoolize/libtool.m4 then just use
> BUILD_DEPENDS=devel/libtool instead.
>
> > > pre-configure:
> > > - ${SUBST_CMD} ${WRKSRC}/src/airodump-ng.h
> > > + cd ${WRKSRC} && AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
> > > + AUTOCONF_VERSION=${AUTOCONF_VERSION} autoreconf -i
>
> use something like this instead: (from memory, needs checking :)
>
> do-gen:
> cd ${WRKSRC} && ${AUTOCONF_ENV} autoreconf -i
>
> > > RCS file: patches/patch-scripts_airodump-ng-oui-update
> > > diff -N patches/patch-scripts_airodump-ng-oui-update
> > > --- /dev/null 1 Jan 1970 00:00:00 -0000
> > > +++ patches/patch-scripts_airodump-ng-oui-update 28 Jan 2019 15:04:26
> > > -0000
> > > @@ -0,0 +1,17 @@
> > > +$OpenBSD$
> > > +
> > > +The Windows line breaks break the terminal output
> > > +requires dos2unix installed,
> > > +sed -i 's/\r$//'
> > > +didn't cut it
> > > +
> > > +Index: scripts/airodump-ng-oui-update
> > > +--- scripts/airodump-ng-oui-update.orig
> > > ++++ scripts/airodump-ng-oui-update
> > > +@@ -90,4 +90,6 @@ else
> > > + exit 1
> > > + fi
> > > +
> > > ++dos2unix ${AIRODUMP_NG_OUI}
> > > ++
>
> Looking at
> https://github.com/aircrack-ng/aircrack-ng/blob/master/scripts/airodump-ng-oui-update
> it seems there are some hardcoded paths (/etc, /usr/local/etc, /usr/share).
>
> But... We already have the OUI database in a couple of formats in
> ports/net/arp-scan,-mac - with the update I just committed I've added a
> new output file that should be in the format aircrack-ng expects.
>
> So if you add a dependency on that and patch the program to use
> ${LOCALBASE}/share/mac-vendor/aircrack-oui.txt instead, users will
> get a reasonably frequently updated file (and then you can drop
> airodump-ng-oui-update with its unnecessary "run wget/curl/dos2unix
> as root" and the step in pkg/README).
>
> > > -@man man/man1/airbase-ng.1
> > > +@bin bin/wpaclean
> > > +lib/libaircrack-crypto-1.3.0.so
> >
> > I guess those are dlopened modules, not shared libs?
> >
> > > +lib/libaircrack-crypto-x86-avx-1.3.0.so
> > > +lib/libaircrack-crypto-x86-avx.a
> > > +lib/libaircrack-crypto-x86-avx.la
> > > +lib/libaircrack-crypto-x86-avx.so
> > > +lib/libaircrack-crypto-x86-avx2-1.3.0.so
> > > +lib/libaircrack-crypto-x86-avx2.a
> > > +lib/libaircrack-crypto-x86-avx2.la
> > > +lib/libaircrack-crypto-x86-avx2.so
> > > +lib/libaircrack-crypto-x86-sse2-1.3.0.so
> > > +lib/libaircrack-crypto-x86-sse2.a
> > > +lib/libaircrack-crypto-x86-sse2.la
> > > +lib/libaircrack-crypto-x86-sse2.so
> >
> > Aren't those x86/amd64 only files?
> >
> > > +lib/libaircrack-crypto.a
> > > +lib/libaircrack-crypto.la
> > > +lib/libaircrack-crypto.so
> > > +lib/libaircrack-osdep-1.3.0.so
> > > +lib/libaircrack-osdep.a
> > > +lib/libaircrack-osdep.la
> > > +lib/libaircrack-osdep.so
>
> Looks like it. And the .a's are probably useless - see if you can
> avoid building them with "LIBTOOL_FLAGS = --tag=disable-static"
>
> Is there a configure flag to use a subdirectory for them?
>
