On 2019/01/28 23:08, Olivier Cherrier wrote:
>       Hi Andrew,
> 
> On Sun, Jan 27, 2019 at 08:24:59PM -0700, and...@afresh1.com wrote:
> > On Sun, Dec 09, 2018 at 01:57:58PM +0000, Olivier Cherrier wrote:
> > > Following https://marc.info/?l=openbsd-ports&m=146753658609587&w=2,
> > > here is a port for p5-Rex.
> > 
> > I see an empty share/examples/p5-Rex directory in the PLIST but don't
> > see anything in the distribution that seems like it should live there,
> > and I'm not actually sure what's creating it.  Probably it should be
> > @comment'ed out.
>  
> Here is a small update … with an example included :)
> 
> > It looks like it needs a TEST_DEPENDS on devel/p5-Test-Deep as well as a
> > new port (attached) of p5-Test-UseAllModules to pass tests.  
>  
> Thanks !
> I added them. It is still failing for me because I have Hash::Merge in
> version 0.300:
> ---8<---
> #   Failed test 'use Rex::CMDB::YAML;'                                       
> #   at /usr/local/libdata/perl5/site_perl/Test/UseAllModules.pm line 71.     
> #     Tried to use 'Rex::CMDB::YAML'.                                        
> #     Error:  Can't locate Clone/Choose.pm in @INC ……
> ---8<---
> 
> It comes from:
> $ grep Choose /usr/local/libdata/perl5/site_perl/Hash/Merge.pm
> use Clone::Choose 0.008;
> $
> 
> With Clone::Choose installed, it ends up successfully.
> This new port is attached and an update of Hash::Merge as well.

Clone::Choose and Hash::Merge read OK but untested.

For Rex, here's a diff to conform better to standard Makefile layout etc.


diff --git Makefile Makefile
index 14439e8..0ba0622 100644
--- Makefile
+++ Makefile
@@ -1,44 +1,42 @@
 # $OpenBSD:$
 
-COMMENT=               (R)?ex Deployment & Configuration Management
+COMMENT=       perl-based deployment and configuration management
 
-HOMEPAGE=              https://www.rexify.org/
+CPAN_AUTHOR=   JFRIED
+DISTNAME=      Rex-1.6.0
 
-CPAN_AUTHOR=           JFRIED
-MODULES=               cpan
+CATEGORIES=    sysutils
 
-DISTNAME =             Rex-1.6.0
-CATEGORIES=            sysutils
+HOMEPAGE=      https://www.rexify.org/
+
+MODULES=       cpan
 
 # Apache 2.0
 PERMIT_PACKAGE_CDROM=   Yes
-MODCPAN_EXAMPLES=      Yes
-
-RUN_DEPENDS=            converters/p5-JSON-XS \
-                       converters/p5-JSON-MaybeXS \
-                       devel/p5-Data-Validate-IP \
-                       devel/p5-Devel-Caller \
-                       devel/p5-Hash-Merge \
-                       devel/p5-IO-String \
-                       devel/p5-List-MoreUtils \
-                       devel/p5-Sort-Naturally \
-                       devel/p5-Test-Pod \
-                       devel/p5-YAML \
-                       net/p5-Net-OpenSSH \
-                       net/p5-Net-SFTP-Foreign \
-                       net/p5-Net-SSH2 \
-                       security/p5-Digest-HMAC \
-                       textproc/p5-Text-Glob \
-                       textproc/p5-XML-Simple \
-                       www/p5-LWP-UserAgent-Determined
-
-TEST_DEPENDS=          devel/p5-Test-Deep \
-                       devel/p5-Test-UseAllModules
 
-post-install:
-                       ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/p5-Rex
-                       ${INSTALL_DATA} ${FILESDIR}/example1.pl \
-                           ${PREFIX}/share/examples/p5-Rex/
+RUN_DEPENDS=   converters/p5-JSON-XS \
+               converters/p5-JSON-MaybeXS \
+               devel/p5-Data-Validate-IP \
+               devel/p5-Devel-Caller \
+               devel/p5-Hash-Merge \
+               devel/p5-IO-String \
+               devel/p5-List-MoreUtils \
+               devel/p5-Sort-Naturally \
+               devel/p5-Test-Pod \
+               devel/p5-YAML \
+               net/p5-Net-OpenSSH \
+               net/p5-Net-SFTP-Foreign \
+               net/p5-Net-SSH2 \
+               security/p5-Digest-HMAC \
+               textproc/p5-Text-Glob \
+               textproc/p5-XML-Simple \
+               www/p5-LWP-UserAgent-Determined
+
+TEST_DEPENDS=  devel/p5-Test-Deep \
+               devel/p5-Test-UseAllModules
 
+post-install:
+       ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/p5-Rex
+       ${INSTALL_DATA} ${FILESDIR}/example1.pl ${PREFIX}/share/examples/p5-Rex/
 
 .include <bsd.port.mk>

Reply via email to