On Mon, Feb 04, 2019 at 06:31:18PM +0000, Linda Lapinlampi wrote: > > Thanks, but your diff does not include the distinfo change. :) > > Thanks for reminding, it didn't get merged locally in my ports. Added. > > > If you want to amend COMMENT fine (no real opinion about the > > previous/new COMMENT). But please do not gratuitously change the > > existing whitespace, it messes up reviews and cvs blame. > > Changed, as requested. I reverted the comment too, because I like the > old comment despite the discrepancy to the description published on PyPI > now. > > > Can't really test with a partial diff, but is that patch really needed? > > Without the patch: > > pyport$ FLAVOR=python3 make test > ===> Building for py3-phonenumbers-8.10.3 > Traceback (most recent call last): > File "./setup.py", line 48, in <module> > long_description = readme.read() > File "/usr/local/lib/python3.6/encodings/ascii.py", line 26, in decode > return codecs.ascii_decode(input, self.errors)[0] > UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position
python3 is sensible to LC_CTYPE environment variable. it could be more simple to explicitly set the env variable with: MAKE_ENV += LC_CTYPE=C.UTF-8 it should permit to avoid patching setup.py. additionally, it seems to me the PLIST should be changed with 8.10.3: phonenumbers/geodata/data28.py is no more present. Thanks. -- Sebastien Marie
