On Mon, Feb 04, 2019 at 07:45:36PM +0000, Linda Lapinlampi wrote: > Hi, matrix-synapse port will want this dependency. > > I disabled running tests; it makes lots of Python os.system calls in a > not very secure way. The main code daemonize.py doesn't seem as bad at > first glance. > > Despite that, this port from GitHub instead of PyPI because of lack of > tests in sources hosted on PyPI.
Well if there's a source on pypi, it's better to use it rather than github, because github can cause issues with tarball generation. Especially if you were planning to disable the tests.... keep the comment mentioning the broken tests in the github source, but please use pypi as source.
