On 2019/02/05 12:55, Renaud Allard wrote: > > > On 2/1/19 3:38 PM, Renaud Allard wrote: > > > > Hi, > > > > I have made a change, in fact setting CURL_POSTFIELDSIZE to 0 when GET > > needs to be used. This resolves the segfault, but the -m option doesn't > > seem to be working yet, but I will report that to the dev. > > > > I also made patches to initialize curl the right way with LONG, limit > > the protocols to HTTP(S) and made it to prefer HTTPS. > > Also, I have changed the useragent to be more modern, and less like the > > default one in esniper. > > > > Best Regards > > Any chances of getting it committed? >
I don't think we should be encouraging its use by having it in ports. Complex string parsing of a frequently updated website, in C, and the above bug isn't a good indication that they are getting things right (why does it even set CURL_POSTFIELDSIZE at all when it's doing a GET? why reuse a stale pointer?) - this is something I'd be wary of even for a standard website. But for something which has your ebay credentials? My comment about https wasn't so much "ports should change this" but more "the developers are insane if they think this is acceptable, what else are they doing wrong".
