On Mon, Feb 11, 2019 at 09:03:52PM +0100, Caspar Schutijser wrote: > Hi, > > $ ldd /usr/local/bin/include-what-you-use | grep libLLVM > 000000885d7d1000 000000886139c000 rlib 0 1 0 > /usr/local/lib/libLLVM-7.so > > Therefore, include-what-you-use won't run unless the llvm package is > installed. The diff below makes sure llvm is installed when the user > installs include-what-you-use but I'm not sure it is the right way > to do it.
Shouldn't it instead be added to LIB_DEPENDS and have a WANTLIB for LLVM-7 ? Dropping IWYU_LLVM_ROOT_PATH seems fine. > > While there; cmake notes the following: > CMake Warning: > Manually-specified variables were not used by the project: > > IWYU_LLVM_ROOT_PATH > > So this diff addresses that as well by removing the CONFIGURE_ARGS. > > Thanks, > Caspar Schutijser > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/devel/include-what-you-use/Makefile,v > retrieving revision 1.14 > diff -u -p -r1.14 Makefile > --- Makefile 28 Jan 2019 06:27:28 -0000 1.14 > +++ Makefile 11 Feb 2019 19:47:08 -0000 > @@ -4,6 +4,7 @@ COMMENT= tool to analyse \#includes in C > CATEGORIES= devel > DISTNAME= include-what-you-use-0.11.src > PKGNAME= include-what-you-use-0.11 > +REVISION= 0 > > HOMEPAGE= http://include-what-you-use.org > MASTER_SITES= ${HOMEPAGE}/downloads/ > @@ -15,13 +16,14 @@ MAINTAINER= Jonathan Gray <[email protected] > PERMIT_PACKAGE_CDROM= Yes > > WANTLIB= c curses execinfo form m pthread z > -BUILD_DEPENDS= devel/llvm>=7.0.1 > +LLVM_V= 7.0.1 > +BUILD_DEPENDS= devel/llvm>=${LLVM_V} > +RUN_DEPENDS= devel/llvm>=${LLVM_V} > LIB_DEPENDS= devel/libexecinfo > > MODULES= devel/cmake lang/python > COMPILER= base-clang ports-gcc > COMPILER_LANGS= c++ > -CONFIGURE_ARGS= -DIWYU_LLVM_ROOT_PATH=${LOCALBASE} > > MODPY_ADJ_FILES = fix_includes.py iwyu_tool.py > >
