On Fri, Feb 22, 2019 at 12:53:06AM +0100, Alexander Bluhm wrote:
> On Thu, Feb 21, 2019 at 11:22:12PM +0100, Charlene Wendling wrote:
> > Here is a new port, String::Formatter. It will be needed for updating
> > audio/p5-Audio-MPD-Common.
>
> I think you should keep String/Formatter/Cookbook.pm, it makes
> perldoc String::Formatter::Cookbook work.
>
> Instead of an extra post-install target, you could just comment out
> bench.pl from PLIST.
>
> @comment ${P5SITE}/String/bench.pl
>
> I don't like the @rm -f. The @ prevents that you see what is going
> on, and with -f it cannot fail. What happens if in a later version
> bench.pl is not part of the distribution? You will never notice
> that rm -f would not work.
>
> with that OK bluhm@
I agree, @comment is the expected way to avoid installing things as long
as it goes through the rest of the build fine.
with bluhm's changes, OK afresh1@
