On Mon, Feb 04, 2019 at 04:50:14PM +0000, Linda Lapinlampi wrote: > Hi, attached is a port for the Python client of Prometheus monitoring > system. > > Description: > This library provides an API for exporting metrics from a Python application, > and an HTTP server to expose the metrics to Prometheus. > > PyPI: https://pypi.org/project/prometheus_client/ > Git: https://github.com/prometheus/client_python > > make test: 1 failed, 191 passed on my amd64 machine. The failing test > is: > > def test_instance_ip_grouping_key(self): > self.assertTrue('' != instance_ip_grouping_key()['instance']) > > def instance_ip_grouping_key(): > '''Grouping key with instance set to the IP Address of this host.''' > with closing(socket.socket(socket.AF_INET, socket.SOCK_DGRAM)) as s: > s.connect(('localhost', 0)) > OSError: [Errno 49] Can't assign requested address > > Please test. It seems the developers skip this one unit test on macOS > too ("does not work on macOS"), according to > tests/test_exposition.py:L290-293.
Having a test failling is not a big deal. > An upcoming matrix-synapse port will depend on this port (although > currently versions >= 0.4.0 of this client are unsupported by > matrix-synapse). I hope this port is also useful standalone. > > Porting quirks: PyPI source doesn't include tests, so this port fetches > the source from GitHub instead. and fetching the sources from github sometimes has issues :) portswise changes: - REVISION should start empty/unset - update the PLIST with python3 FLAVOR, as is the default FLAVOR doesnt package. Creating package py-prometheus_client-0.5.0 Error: duplicate item in packing-list /usr/local/lib/python2.7/site-packages/prometheus_client Error: duplicate item in packing-list /usr/local/lib/python2.7/site-packages/prometheus_client/bridge Error: duplicate item in packing-list /usr/local/lib/python2.7/site-packages/prometheus_client/openmetrics Error: duplicate item in packing-list /usr/local/lib/python2.7/site-packages/prometheus_client/twisted (see about MODPY_COMMENT in the PLIST) with that fixed, ok to import (as py-frozendit & py-daemonize with the comments it did adressed) Landry
