On Fri, Feb 22 2019, "Elias M. Mariani" <[email protected]> wrote:
> On Fri, Feb 22, 2019 at 7:05 AM Jeremie Courreges-Anglas <[email protected]>
> wrote:
>> I don't understand the SETENV variable. Where is it used?
> In the MODULE = lang/python.
> Is needed to parse a file by setup.py.
Ah ha, I was a bit confused.
python.port.mk:
--8<--
MODPY_CMD = cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} \
${MODPY_BIN} ./${MODPY_SETUP} \
${MODPY_SETUP_ARGS}
MODPY_TEST_CMD = cd ${WRKSRC} && ${SETENV} ${ALL_TEST_ENV} \
${MODPY_BIN} ./${MODPY_SETUP} \
${MODPY_SETUP_ARGS}
-->8--
What you want is to add your LC_CTYPE override to MAKE_ENV. Touching
SETENV like this neuters the effects of its default value, 'env -i',
which is a requirement to get reproducible builds. Recently (I don't
have a link at hand), folks have been discussing making SETENV
read-only/removing the variable.
>> The two additional diffs below allow me to run tests successfully on
>> amd64.
>
> Great! Thank you.
>
> Commiting later today.
Not ok with using SETENV. ok jca@ if you use MAKE_ENV instead *and* if
you know that consumer ports can cope with this update.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
