On Sun, Mar 03 2019, Olivier Taïbi <o...@olitb.net> wrote: > Here is an update for x11/girara (a library that it only used by > textproc/zathura, so this update is motivated by an upcoming update for > zathura) > from version 0.3.0 to version 0.3.2. A patch for tests becomes unnecessary. I > compared the output of nm -g oldlib.so.X.Y | cut -c10- | grep -e^T and <same > for > newlib> as suggested in the doc, and the dif is below: > > 3,25d2 > < T acos > < T atan2 > < T ceil > < T cos > < T exp > < T exp2 > < T feclearexcept > < T fedisableexcept > < T feenableexcept > < T fegetenv > < T fegetexcept > < T fegetexceptflag > < T fegetround > < T feholdexcept > < T feraiseexcept > < T fesetenv > < T fesetexceptflag > < T fesetround > < T fetestexcept > < T feupdateenv > < T floor > < T floorf > < T fmod > 167,181d143 > < T hypot > < T log10 > < T log2 > < T lrint > < T nearbyint > < T nearbyintf > < T nearbyintl > < T pow > < T rint > < T rintf > < T round > < T scalbn > < T sin > < T tan > < T trunc > > so only functions from the standard library... I'm not sure why this is, but I > guess no version bump is needed for the SHARED_LIBS version.
Technically some exported symbols have been removed, so it would be a major bump. But said symbols aren't exported any more because meson.build now uses "gnu_symbol_visibility: 'hidden'" to build the library. Feel free to skip the major bump if you know that zathura linked against girara-0.3.0 works fine when using the library from girara-0.3.2. BTW there is a nice tool to check changes in exported symbols: /usr/src/lib/check_sym > I have not been > able to "make test" yet (I am building in a chroot and X is needed), but it > works well for me with the new zathura. Apart from the major bump concern, I have noticed the following points that could be improved: - HOMEPAGE / MASTER_SITES could switch to https - WANTLIB should be refreshed (make port-lib-depeends-check) - libnotify is not picked up by default any more, is should either be explicitely activated or removed from LIB_DEPENDS > diff -uNprx CVS /usr/ports/x11/girara/Makefile > /build/usr/ports/x11/girara/Makefile > --- /usr/ports/x11/girara/Makefile Wed Sep 19 11:35:19 2018 > +++ /build/usr/ports/x11/girara/Makefile Sat Mar 2 11:59:33 2019 This makes your diff hard to apply. If you can't use cvs diff, please at least do something like: cd /build/usr/ports/x11/girara/ && diff -uNprx CVS /usr/ports/x11/girara . so that we don't have to guess the pathname strip count. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
