On Mon, Mar 04, 2019 at 08:39:48PM +0100, Klemens Nanni wrote:
> On Sun, Mar 03, 2019 at 09:33:58PM +0100, Charlene Wendling wrote:
> > Because of the new colorscheme algo (decoupled colors), it seems that
> > it needs more contrast for "active" elements, and there is too much
> > gray in our colorscheme.
> Yes, currently the colors are the same so there's no contrast at all.
>
> > I'm proposing here a diff that changes to a more appropriate color
> > for active elements and blends decently with the grayish theme as
> > a PoC... or we may just switch to default values.
> That works, but I also prefer dropping our local patches and stick with
> upstream defaults; same thing with x11/dmenu.
>
> If users want to change a bit, they have to recompile themselves anyway,
> so that won't bite those who care (and customize by now already).
>
> Feedback? Objections? OK?
In the past the argument for keeping the customized grayish color scheme
was to provide a unified experience across the suckless tools dwm, dmenu,
st, and tabbed in OpenBSD. They all use the same hex codes providing a
similar look&feel.
I'm fine with dropping the gray scheme and using defaults instead, but
then it should be dropped from the other tools (demnu + tabbed + st) as
well.
Instead of dropping, I would prefer the slight tweak below to dwm which
combines Charlene's hex suggestion with a SchemeSel tweak to makes it
look more like in the previous releases.
But I'm really fine with either way - just let's be consistent across
these tools.
Index: patches/patch-config_def_h
===================================================================
RCS file: /cvs/ports/x11/dwm/patches/patch-config_def_h,v
retrieving revision 1.14
diff -u -p -r1.14 patch-config_def_h
--- patches/patch-config_def_h 12 Feb 2019 17:05:03 -0000 1.14
+++ patches/patch-config_def_h 4 Mar 2019 20:29:31 -0000
@@ -2,7 +2,7 @@ $OpenBSD: patch-config_def_h,v 1.14 2019
Index: config.def.h
--- config.def.h.orig
+++ config.def.h
-@@ -5,13 +5,13 @@ static const unsigned int borderpx = 1; /* bor
+@@ -5,17 +5,17 @@ static const unsigned int borderpx = 1; /* bor
static const unsigned int snap = 32; /* snap pixel */
static const int showbar = 1; /* 0 means no bar */
static const int topbar = 1; /* 0 means bottom bar */
@@ -19,10 +19,15 @@ Index: config.def.h
+static const char col_gray2[] = "#404040";
+static const char col_gray3[] = "#c0c0c0";
+static const char col_gray4[] = "#f0f0f0";
-+static const char col_cyan[] = "#404040";
++static const char col_cyan[] = "#a0a0aa";
static const char *colors[][3] = {
/* fg bg border */
[SchemeNorm] = { col_gray3, col_gray1, col_gray2 },
+- [SchemeSel] = { col_gray4, col_cyan, col_cyan },
++ [SchemeSel] = { col_gray4, col_gray2, col_cyan },
+ };
+
+ /* tagging */
@@ -29,6 +29,9 @@ static const Rule rules[] = {
/* class instance title tags mask isfloating
monitor */
{ "Gimp", NULL, NULL, 0, 1, -1 },
