On 3/4/19 10:48 PM, Jeremie Courreges-Anglas wrote:
On Mon, Mar 04 2019, Brian Callahan <[email protected]> wrote:
Hi ports --
x11/jgmenu doesn't have a COMPILER line set. base-gcc does not
understand all the warnings listed in the Makefile. If we remove those
warnings, then base-gcc will compile jgmenu just fine.
No bump, since this doesn't change the package in any way.
Noticed while reading through the latest macppc ports bulk logs.
OK?
It may be easier to just switch to ports-gcc instead of patching the
Makefile at a place where conflicts seem likely. ok jca@ either way
I thought about this and couldn't come to a conclusion about which was
the path of least resistance.
I think I'll go for forcing the compiler; seems slightly nicer than
maintaining another patch.
Thanks.
~Brian
~Brian
Index: patches/patch-Makefile
===================================================================
RCS file: /cvs/ports/x11/jgmenu/patches/patch-Makefile,v
retrieving revision 1.1
diff -u -p -r1.1 patch-Makefile
--- patches/patch-Makefile 26 Feb 2019 16:16:05 -0000 1.1
+++ patches/patch-Makefile 5 Mar 2019 01:18:56 -0000
@@ -1,9 +1,11 @@
$OpenBSD: patch-Makefile,v 1.1 2019/02/26 16:16:05 sthen Exp $
+-Wvla, -Wunused-result not understood by base-gcc
+
Index: Makefile
--- Makefile.orig
+++ Makefile
-@@ -24,7 +24,7 @@ else
+@@ -24,10 +24,10 @@ else
datarootdir= $(prefix)/share
endif
@@ -11,7 +13,11 @@ Index: Makefile
+CFLAGS += -Wall -std=gnu89
CFLAGS += -Wextra -Wdeclaration-after-statement -Wno-format-zero-length \
-Wold-style-definition -Woverflow -Wpointer-arith \
- -Wstrict-prototypes -Wunused -Wvla -Wunused-result
+- -Wstrict-prototypes -Wunused -Wvla -Wunused-result
++ -Wstrict-prototypes -Wunused
+ CFLAGS += -Wno-unused-parameter
+ CFLAGS += -DVERSION='"$(VER)"'
+
@@ -100,18 +100,18 @@ $(DEPDIR)/%.d: ;
.PRECIOUS: $(DEPDIR)/%.d
